Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use dune 3.16.0 #1496

Merged
merged 4 commits into from
Jun 18, 2024
Merged

use dune 3.16.0 #1496

merged 4 commits into from
Jun 18, 2024

Conversation

emillon
Copy link
Collaborator

@emillon emillon commented Jun 5, 2024

(will update PR as release process progresses)

@emillon emillon mentioned this pull request Jun 5, 2024
20 tasks
@anmonteiro
Copy link
Collaborator

a few issues here

  • macOS failures failing to find <atomic.h>
  • melange broken on 5.2 (what's this new flags -bin-annot-occurrences?)

@emillon
Copy link
Collaborator Author

emillon commented Jun 7, 2024

  • -bin-annot-occurrences is a new flag in 5.2 that tells the compiler to add "shape" information in the cmt files. Dune will use that if available. If dune drives melc like an ocaml compiler, I think you'll have to add an ignored flag.
  • the atomic failures do happen on dune 3.15.3 don't they? in that case that's an issue with how 5.2 is built on nix

@anmonteiro
Copy link
Collaborator

  • the atomic failures do happen on dune 3.15.3 don't they? in that case that's an issue with how 5.2 is built on nix

I don’t remember, but 5.2 has been supported for a while; why would it be a packaging bug when the dune upgrade introduced it?

@anmonteiro
Copy link
Collaborator

  • the atomic failures do happen on dune 3.15.3 don't they? in that case that's an issue with how 5.2 is built on nix

I don’t remember, but 5.2 has been supported for a while; why would it be a packaging bug when the dune upgrade introduced it?

ah I see it in other places, too. I think it's minisat that's badly packaged upstream.

@anmonteiro
Copy link
Collaborator

This now works after having released Melange 4.0.1-52 with support for -bin-annot-occurrences.

@emillon
Copy link
Collaborator Author

emillon commented Jun 10, 2024

great, thanks. I'm keeping this open to test the next alpha.

@anmonteiro anmonteiro marked this pull request as ready for review June 18, 2024 04:05
@anmonteiro anmonteiro merged commit b01faf3 into master Jun 18, 2024
18 checks passed
@anmonteiro anmonteiro deleted the dune-3.16.0 branch June 18, 2024 06:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants