Add Users and Group related functions
#1139
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
So what's the plan? What do you expect to add in a follow up PR? |
Closed
|
@asomers we did not include the iterators here and I'd like to extend it after this is merged as it is independent and allow for reducing the code to work/review. Do you mind to go over this here so we clean any leftover and merge this one? |
|
@asomers any comment on this one? |
asomers
reviewed
Oct 30, 2019
|
@asomers I made the changes. Please let me know if something else is still needed. |
|
Now that you no longer |
This was a collaborative work between Johannes Schilling <[email protected]>, Fredrick Brennan <[email protected]> and myself. Signed-off-by: Otavio Salvador <[email protected]>
Just did; sorry for missing that. |
|
@asomers fixed the unnecessary |
otavio
added a commit
to ctrlcctrlv/nix
that referenced
this pull request
Oct 31, 2019
This was a collaborative work between Johannes Schilling <[email protected]>, Fredrick Brennan <[email protected]> and myself. This is a continuation of nix-rust#1139. Signed-off-by: Otavio Salvador <[email protected]>
bors bot
added a commit
that referenced
this pull request
Nov 1, 2019
1139: Add `Users` and `Group` related functions r=asomers a=otavio This was a collaborative work between Johannes Schilling <[email protected]>, Fredrick Brennan <[email protected]> and myself. This PR is a split-off from #864 so we merge ready parts first. Next, we work on the iterators. Signed-off-by: Otavio Salvador <[email protected]> Co-authored-by: Otavio Salvador <[email protected]>
Build succeeded
|
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was a collaborative work between Johannes Schilling
[email protected], Fredrick Brennan [email protected]
and myself.
This PR is a split-off from #864 so we merge ready parts first. Next, we work on the iterators.
Signed-off-by: Otavio Salvador [email protected]