Add SO_BINDTODEVICE sockopt #1233
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Tested on |
|
All new features in Nix require a CHANGELOG and a test. Can you please add those? |
|
@asomers Yeah, I'll do it. |
jeandudey
force-pushed
the
2020_05_08-so-bindtodevice
branch
from
c33cfbb to
10ebf45
Compare
|
@asomers Changes addressed |
asomers
requested changes
May 8, 2020
This is available only on Linux as far I know, [socket(7)](https://linux.die.net/man/7/socket) has some information about the `SO_BINDTODEVICE` sockopt. In simple words it binds a socket to an specific network device (specified as an string like "wlo1", "eth0", etc.), to only process packets from that device. Signed-off-by: Jean Pierre Dudey <[email protected]>
jeandudey
force-pushed
the
2020_05_08-so-bindtodevice
branch
from
10ebf45 to
1686f6d
Compare
asomers
approved these changes
May 8, 2020
|
Thanks for your review! |
|
Build succeeded: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is available only on Linux as far I know, socket(7) has some information
about the
SO_BINDTODEVICEsockopt. In simple words it binds a socketto an specific network device (specified as an string like "wlo1",
"eth0", etc.), to only process packets from that device.
Note: this is untested (for now, i'll test it today), but should work out of the box.