Raise MSRV to 1.40.0 #1358
Merged
Raise MSRV to 1.40.0 #1358
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This will shortly be needed for Fuchsia support.
|
I saw that same musl issue in my PR (https://github.com/nix-rust/nix/pull/1285/files#diff-c2454cd83dd7725daae35caff3a062f117176b9d4922393e97307b2a91e2aa12L1073). I guess this is the cause of the mac failures. Thanks for investigating. I'll watch this PR. |
In older versions of Musl, ttyname_r would wrongly return ENOTTY instead of EBADF. We expected that bug in our test suite. But Rust 1.37.0 updated Musl to 1.1.22, which fixes the problem. This change reverts our workaround. https://www.openwall.com/lists/musl/2018/09/15/2 rust-lang/rust@aaf6698
Merged
|
@posborne @kamalmarhubi do either of you have a Mac and want to try debugging the OSX failure? It fails every time. But when I add a line of debugging just above the |
kamalmarhubi
approved these changes
Dec 11, 2020
On Cirrus-CI, this test frequently fails with EINVAL. The error goes away if I add a line of debugging, so it's probably a timing issue. But I can't debug it myself. Issue nix-rust#1361
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will shortly be needed for Fuchsia support.