Add format test to CI #1748
Merged
Add format test to CI #1748
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
costinsin
force-pushed
the
fmt_testing
branch
5 times, most recently
from
6498cee to
8a17256
Compare
asomers
requested changes
Jun 20, 2022
.cirrus.yml
Outdated
| @@ -18,6 +18,8 @@ build: &BUILD | |||
| - . $HOME/.cargo/env || true | |||
| - $TOOL +$TOOLCHAIN -Vv | |||
| - rustc +$TOOLCHAIN -Vv | |||
| - if [ -z "$TOOLCHAIN" ]; then rustup component add rustfmt; else rustup +$TOOLCHAIN component add rustfmt; fi | |||
| - $TOOL +$TOOLCHAIN fmt --all -- --check | |||
There was a problem hiding this comment.
cargo fmt ignores cfg directives, so running it once suffices to provide coverage for every OS. Running it on every OS is duplicative. Instead, you should either create a new task just for this, or else put it into the "Rust Stable" task.
There was a problem hiding this comment.
I have created a new CI task. This way, if this is the only test failing, the person who submitted the PR will easily know that the PR failed due to bad formatting. I have tested the commit without applying the formatting changes and everything seems fine
There was a problem hiding this comment.
I have also added the rustfmt.toml file specifying that the max width needs to be 80 characters.
costinsin
force-pushed
the
fmt_testing
branch
2 times, most recently
from
ffaf9f9 to
f3da089
Compare
rtzoeller
reviewed
Jun 23, 2022
To enforce uniformity for all PRs, the CI checks if the code is formatted rigth using `cargo fmt` tool. Signed-off-by: Costin-Robert Sin <[email protected]>
Signed-off-by: Costin-Robert Sin <[email protected]>
This was referenced Nov 6, 2022
Merged
bors bot
added a commit
that referenced
this pull request
Nov 12, 2022
1854: Reformat everything r=rtzoeller a=SUPERCILEX Unfortunately, #1748 didn't do the trick because of rust-lang/rustfmt#3253. This PR fully enforces global formatting. Closes #770 Co-authored-by: Alex Saveau <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To enforce uniformity for all PRs, the CI checks if the code
is formatted right using
cargo fmttool.Results after implementing the format test in CicleCI, but before fixing the format errors: https://cirrus-ci.com/build/4684991404703744
Results after fixing the format errors: https://cirrus-ci.com/build/5423803479097344
Solves #770