Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

re-export RLIM_INFINITY from libc #1831

Merged
merged 1 commit into from
Oct 8, 2022
Merged

re-export RLIM_INFINITY from libc #1831

merged 1 commit into from
Oct 8, 2022

Conversation

SteveLauC
Copy link
Member

Fixes #1803

@SteveLauC
Copy link
Member Author

PR #1830 was accidentally closed, but I didn't click that close button at all, seems to be a GitHub bug, so weird:(

rtzoeller
rtzoeller approved these changes Oct 2, 2022
View reviewed changes
Copy link
Collaborator

@rtzoeller rtzoeller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

bors r+

bors bot added a commit that referenced this pull request Oct 2, 2022
@bors @SteveLauC
Merge #1831
489d7cf 
1831: re-export RLIM_INFINITY from libc r=rtzoeller a=SteveLauC

Fixes #1803 

Co-authored-by: Steve Lau <[email protected]>
@bors
Copy link
Contributor

bors bot commented Oct 2, 2022

Timed out.

@SteveLauC
Copy link
Member Author

Test timed out, could we give it a retry?

@rtzoeller
Copy link
Collaborator

bors retry

bors bot added a commit that referenced this pull request Oct 3, 2022
@bors @SteveLauC
Merge #1831
482a596 
1831: re-export RLIM_INFINITY from libc r=rtzoeller a=SteveLauC

Fixes #1803 

Co-authored-by: Steve Lau <[email protected]>
@SteveLauC
Copy link
Member Author

This is kinda weird, the test has been running for an hour. Perhaps there is something wrong with the CI?

@bors
Copy link
Contributor

bors bot commented Oct 3, 2022

Timed out.

@SteveLauC SteveLauC mentioned this pull request Oct 5, 2022
Merged
@rtzoeller
Copy link
Collaborator

We'll see if it was a transient issue.

bors retry

@bors
Copy link
Contributor

bors bot commented Oct 8, 2022

Build succeeded:

@bors bors bot merged commit e5913c6 into nix-rust:master Oct 8, 2022
@SteveLauC SteveLauC deleted the reexport-RLIM_INFINITY branch October 8, 2022 01:14
bors bot added a commit that referenced this pull request Oct 8, 2022
@bors @SteveLauC
Merge #1833
0eebf19 
1833: add syncfs on linux r=rtzoeller a=SteveLauC

Fixes #1818 

Change has not been added to `CHANGELOG.md`, will add it when #1831 is merged, or there will be a merge conflict

Co-authored-by: Steve Lau <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rtzoeller rtzoeller rtzoeller approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Should maybe clarify that RLIM_INFINITY comes from libc
2 participants
@SteveLauC @rtzoeller