PyTorch: patch libdrm path for ROCm #24
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This does not quite fix #13 or #2 since GFX800 cards will not work due to https://raw.githubusercontent.com/John-Gee/rocm-arch/d6812d308fee3caf2b6bb01b4d19fe03a6a0e3bd/rocm-opencl-runtime/enable-gfx800.patch not being included in the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Patches the ROCm variant of PyTorch to look for
amdgpu.idsin/tmp/nix-pytorch-rocm___/amdgpu.idsinstead of the default/opt/amdgpu/share/libdrm/amdgpu.ids(underscore padding for same path length since we're patching a binary). Also adds scripts to InvokeAI and KoboldAI to link the correct file to this location if required.Bonus: Sets
HSA_OVERRIDE_GFX_VERSIONto10.3.0by default in InvokeAI and KoboldAI, ensuring that these work on consumer GPUs (as per AMD documentation).