Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: add StatefulSet templates #31

Merged
merged 6 commits into from
Feb 16, 2023
Merged

Conversation

GRomR1
Copy link
Contributor

@GRomR1 GRomR1 commented Nov 16, 2022

Hi all

I would like add this two useful features

  • extract a Pod spec from Deployment to _pod.tpl file (don't change anything inside except indenting)
  • add a capability to create StatefulSet based on this tpl

Inspired by this chart.

Also the common sample with name web-app.values.yml is great but is complex to understand a base idea and run a simple test. I add a new two examples that easy to run.

@GRomR1
Copy link
Contributor Author

GRomR1 commented Nov 17, 2022

@randreev1321 could you pls review this PR?

@randreev1321 randreev1321 self-assigned this Nov 21, 2022
@randreev1321
Copy link
Collaborator

Hi @GRomR1.

Thanks for your activity and suggestion. Looks wery nice!

Could you add the usage of the pod template for other workloads as well?

@randreev1321
Copy link
Collaborator

Think it'll be better to finish this PR before #32

@GRomR1
Copy link
Contributor Author

GRomR1 commented Nov 22, 2022

@randreev1321

helm-hooks and job I can't test, cron-job tested with this command:

❯ helm template whoami \
  --values ./samples/cron-jobs.values.yml  \
  ./ | k apply -f - --dry-run=client
cronjob.batch/whoami-flush-cache created (dry run)
cronjob.batch/whoami-mailing created (dry run)
cronjob.batch/whoami-report created (dry run)

@rantanevich
Copy link

By the way, you can also define helpers.container template and use it to declare containers and initContainers in your helpers.pod.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants