Update fnc_doCallout #355
Merged
Update fnc_doCallout #355
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since Arma 3 v2.10, leading slashes are allowed for playSound3D, so no need to bother removing it.
The callout is now played from the unit's eyePos instead of their position.
rekterakathom
added a commit
to rekterakathom/LambsDanger
that referenced
this pull request
May 28, 2024
Reverts a part of nk3nny#355 because of recent discovery that files included in addons must not have a leading slash
jokoho48
pushed a commit
that referenced
this pull request
Oct 14, 2024
Reverts a part of #355 because of recent discovery that files included in addons must not have a leading slash
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When merged this pull request will: Improve
fnc_doCalloutRemove some obsolete code and makes sound originate roughly from the unit's face. Improves caching performance and makes the callout a bit more realistic with zero performance penalty.
Edit: The leading slash can be removed because since Arma 3 v2.10
playSound3Dsimply ignores the slash so it doesn't need to be manually removed. Source: BikiRemove obsolete code (since Arma 3 v2.10) from caching logic
Make callout sound originate from unit's
eyePosinstead of their position