Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added possibility to pass custom function for element measurement #21

Merged
merged 1 commit into from
Jan 17, 2017
Merged

Added possibility to pass custom function for element measurement #21

merged 1 commit into from
Jan 17, 2017

Conversation

Andarist
Copy link
Contributor

closes #20

nkbt
nkbt approved these changes Jan 17, 2017
View reviewed changes
Copy link
Owner

@nkbt nkbt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perfect!

@nkbt
Copy link
Owner

nkbt commented Jan 17, 2017

There are some build issues, but they are not related to this PR. Selenium needs to be updated and codecov token expired. Nevermind...

@nkbt nkbt merged commit 548eea7 into nkbt:master Jan 17, 2017
@Andarist
Copy link
Contributor Author

Wow, that was fast :) Do you have any estimate for the new release?

@nkbt
Copy link
Owner

nkbt commented Jan 17, 2017 via email

@Andarist
Copy link
Contributor Author

K, keeping my fingers crossed. Cheers!

@nkbt
Copy link
Owner

nkbt commented Jan 17, 2017

@nkbt
Copy link
Owner

nkbt commented Jan 17, 2017

Hopefully builds were ok under win, and everything works just fine

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nkbt nkbt nkbt approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Feature request] option to include border in the measurement
2 participants
@Andarist @nkbt