Fix most of the code warnings #2519
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…headers. IDictionary.Add will throw an ArgumentException when attempting to add a duplicate key.
…ing was intended.
…ember '...'. Add the Obsolete attribute to '...'.
…nously. Consider using the 'await' operator to await non-blocking API calls, or 'await Task.Run(...)' to do CPU-bound work on a background thread.
…den member (possibly because of nullability attributes).
… dependency. Either modify the version spec of dependency "OpenTelemetry.Instrumentation.Process [0.5.0-beta.7, )" or update the version field in the nuspec.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes most of the code warnings that are in the codebase. There is a separate commit for every warning type.
There still are 4 instances of warning CS0649 Field '…' is never assigned to, and will always have its default value null:
PauseAfterEachItem._OptionsKeepOutboundLinkTargetProcessor._optionsOutboundLinkCheckingProcessor._optionsTfsWorkItemOverwriteAreasAsTagsProcessor._configAs the warning states, these are fields which are declared, but are never set ad hence the value is
null. The problem is, I cannot remove these fileds, because they are used in code. So I believe, that those classes (or at least those specific code paths) are not used at all, because it would fail withNullReferenceException. The only possibility is, that the values are set somewhere by reflection? So I will leave these warnings to someone else to look at them.