TfsUserMappingTool: fix loading users from TFS connected to Active Directory

[satano]

TfsUserMappingTool is not working correctly in our scenario, which is:

• As our source server, we have on-premise TFS 2018 connected to on-premise Active Directory.
• As our target server, we have Azure DevOps connected to Azure Entra ID (formerly Azure Active Directory).

TfsUserMappingTool is not working at all, because it will not load any user from our on-premise TFS server. The problem is this part:

var people = SIDS.Members.ToList().Where(x => x.Contains("\\")).Select(x => x);

It processes only users, whose SID contains \ character. But none of our users in TFS contains this. All data in SIDS.Members are SIDs of some kind of identity and we need to process them all. So the new logic is this:

• All SIDs are processed, so identity for every one of them is retrieved from the server.
• Identity type is checked if we can use this identity. Allowed identity types for mapping are WindowsUser and UnknownIdentityType.
  • All identities in Entra ID have type UnknownIdentityType.

This works as expected and loads correct user lists from TFS and DevOps.

[MrHinsh]

Looks good.. yea I never tacked this as I don't have access to AD any more ;)