forked from GoogleCloudPlatform/public-datasets-pipelines
-
Notifications
You must be signed in to change notification settings - Fork 0
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
chore: Revised PR template (GoogleCloudPlatform#409)
- Loading branch information
1 parent
be735e9
commit e4763ca
Showing
1 changed file
with
17 additions
and
7 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -4,17 +4,27 @@ Note: If you are adding or editing a dataset, please specify the dataset folder | |
|
||
## Checklist | ||
|
||
Note: If an item applies to you, all of its sub-items must be fulfilled | ||
|
||
- [ ] **(Required)** This pull request is appropriately labeled | ||
- [ ] Please merge this pull request after it's approved | ||
|
||
Use the sections below based on what's applicable to your PR and delete the rest: | ||
|
||
### Feature | ||
- [ ] I'm adding or editing a feature | ||
- [ ] I have updated the [`README`](https://github.com/GoogleCloudPlatform/public-datasets-pipelines/blob/main/README.md) accordingly | ||
- [ ] I have added tests for the feature | ||
- [ ] I have updated the [`README`](https://github.com/GoogleCloudPlatform/public-datasets-pipelines/blob/main/README.md) accordingly | ||
- [ ] I have added/revised tests for the feature | ||
|
||
### Data Onboarding | ||
- [ ] I'm adding or editing a dataset | ||
- [ ] The [Google Cloud Datasets team](mailto:[email protected]) is aware of the proposed dataset | ||
- [ ] I put all my code inside `datasets/<DATASET_NAME>` and nothing outside of that directory | ||
- [ ] The [Google Cloud Datasets team](mailto:[email protected]) is aware of the proposed dataset | ||
- [ ] I put all my code inside `datasets/<DATASET_NAME>` and nothing outside of that directory | ||
|
||
### Documentation | ||
- [ ] I'm adding/editing documentation | ||
|
||
### Bug fix | ||
- [ ] I'm submitting a bugfix | ||
- [ ] I have added tests to my bugfix (see the [`tests`](https://github.com/GoogleCloudPlatform/public-datasets-pipelines/tree/main/tests) folder) | ||
- [ ] I have added/revised tests related to my bugfix (see the [`tests`](https://github.com/GoogleCloudPlatform/public-datasets-pipelines/tree/main/tests) folder) | ||
|
||
### Code cleanup or refactoring | ||
- [ ] I'm refactoring or cleaning up some code |