Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

simplify repeated ifelse #800

Merged
merged 7 commits into from
Nov 21, 2024
Merged

simplify repeated ifelse #800

merged 7 commits into from
Nov 21, 2024

Conversation

billdenney
Copy link
Contributor

Fix #798

@billdenney billdenney linked an issue Oct 24, 2024 that may be closed by this pull request
Simplify repeated ifelse #798
Closed
@mattfidler
Copy link
Member

I agree the code is more readable.

However, this makes dplyr an Imports instead of a Suggests; we are/were close to the 20 threshold so I don't know if this is a good idea because of CRAN requirements.

@mattfidler mattfidler merged commit 42b4a6e into main Nov 21, 2024
6 of 7 checks passed
@mattfidler mattfidler deleted the 798-simplify-repeated-ifelse branch November 21, 2024 21:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Simplify repeated ifelse
2 participants
@billdenney @mattfidler