sources.nix: Use the fetcher instead of creating derivations #32
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
JSON attributes are exposed in the |
nlewo
force-pushed
the
no-longer-manual-derivation
branch
from
dbeedac to
6ae7f5c
Compare
The created derivations were not enough well created to be handled by Hydra as a package [1]. Basically, Hydra recurses on the provided attribute set to figure out which attribute is a derivation. If an attribute set contains an attribut `type="derivation"`, it is consider as a derivation. But Hydra requires also more attributes such as a `name`, `system`... Since we are now using fetchers from `nixpkgs`, we can directly use them since they return a derviation. [1] I add all Niv derivations as packages in Hydra in order to copy them to the binary cache since it is no done at evaluation time.
This `niv` attribute set contains all JSON attributes. JSON attributes are exposed in the `niv` attribute set inside the derivation to avoid name collision on the `type` attribute for instance. Note this is a breaking change since JSON attributes were in the derivation attribute set directly.
nlewo
force-pushed
the
no-longer-manual-derivation
branch
from
6ae7f5c to
7243969
Compare
|
I close it to avoid breaking backward compatibility. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The created derivations were not enough well created to be handled by
Hydra as a package [1]. Basically, Hydra recurses on the provided
attribute set to figure out which attribute is a derivation. If an
attribute set contains an attribut
type="derivation", it is consideras a derivation. But Hydra requires also more attributes such as a
name,system...Since we are now using fetchers from
nixpkgs, we can directly usethem since they return a derviation.
[1] I add all Niv derivations as packages in Hydra in order to copy
them to the binary cache since it is no done at evaluation time.