New update mechanism #68
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Note to self: it'd be better to discarded the |
nlewo
reviewed
Jun 10, 2019
| @@ -11,6 +11,6 @@ export NIX_PATH="nixpkgs=./nix" | |||
| echo "Building" | |||
|
|
|||
| # Build and create a root | |||
| nix-build --no-link | |||
| nix-build --sandbox --no-link --max-jobs 10 | |||
There was a problem hiding this comment.
Does it work with the default Nix installation (sanboxing is not available)?
There was a problem hiding this comment.
What do you mean default Nix installation? On both Linux and macOS sandbox works for me by using the default installer (and nothing more) (albeit with some tweaks on macOS).
We do want to test that everything works with the sandbox; if someone doesn't have support for the sandbox they can simply run nix-build.
What do you think?
There was a problem hiding this comment.
I though sandbox was not working by using the default installer. So, if it is working by default, that's fine with me.
This was referenced Jun 13, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #36 .
Got a few things to clean up, but this will greatly facilitate the move to multiple fetchers, and fixes a few bugs.
Update, which takes care of lazy loading the IO actions (not run if never read or if value will eventually be discarded)StringtoTextFew things left to iron out:
foo,bar,baz, etcCC @nlewo @michaelpj