Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GITHUB_TOKEN env variable support for github fetcher #94

Merged
merged 2 commits into from
Jun 16, 2019
Merged

GITHUB_TOKEN env variable support for github fetcher #94

merged 2 commits into from
Jun 16, 2019

Conversation

kubek2k
Copy link
Contributor

@kubek2k kubek2k commented Jun 16, 2019 •
edited
Loading

it fixes the issue with rate limiting in certain environments (like ZuriHac ;) )

@michaelpj
Copy link
Contributor

Legit compile error.

nmattia
nmattia approved these changes Jun 16, 2019
View reviewed changes
Copy link
Owner

@nmattia nmattia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is great, thanks!

@nmattia nmattia merged commit d656395 into nmattia:master Jun 16, 2019
@kubek2k kubek2k deleted the github-token-support branch June 16, 2019 14:49
@domenkozar
Copy link
Contributor

Nice! It would be a tiny bit better to use netrc for convenience.

@kubek2k
Copy link
Contributor Author

kubek2k commented Jun 19, 2019

@domenkozar I think this is an intermediate step towards use of fetchFromGithub anyway.

@nmattia
Copy link
Owner

nmattia commented Jun 19, 2019

Unfortunately I doubt it'll help: #62 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nmattia nmattia nmattia approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@kubek2k @michaelpj @domenkozar @nmattia