Add API for get single merge request, create note on merge request, get pipelines for merge request, delete for webhooks #137
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@saber-wang test failed: https://github.com/nmklotas/GitLabApiClient/pull/137/checks?check_run_id=585099995#step:9:90 What prevents on from extending Yes some of it might be empty when requesting multiple MRs, however I do not see a harm in that. |
|
no need to close the PR, you can just push your changes to the branch |
I don't know why the test failed
I'm just worried about misdirection |
Codecov Report
@@ Coverage Diff @@
## master #137 +/- ##
==========================================
- Coverage 71.59% 71.16% -0.43%
==========================================
Files 162 164 +2
Lines 2299 2362 +63
==========================================
+ Hits 1646 1681 +35
- Misses 653 681 +28
|
|
@saber-wang the test failure is pretty clear 🤔 |
jetersen
approved these changes
Apr 17, 2020
Codecov Report
@@ Coverage Diff @@
## master #137 +/- ##
==========================================
- Coverage 71.19% 70.84% -0.36%
==========================================
Files 169 170 +1
Lines 2350 2404 +54
==========================================
+ Hits 1673 1703 +30
- Misses 677 701 +24
|
jetersen
reviewed
May 30, 2020
Comment on lines
1
to
12
| using System; | ||
| using System.Collections.Generic; | ||
| using System.Text; | ||
|
|
||
| namespace GitLabApiClient.Models | ||
| { | ||
| public class PageQuery | ||
| { | ||
| public int? Page { get; set; } | ||
| public int? Per_Page { get; set; } | ||
| } | ||
| } |
There was a problem hiding this comment.
I forgot to delete it. I'll fix it
jetersen
changed the title
jetersen
approved these changes
May 30, 2020
MindaugasLaganeckas
pushed a commit
to MindaugasLaganeckas/GitLabApiClient
that referenced
this pull request
Mar 9, 2021
…et pipelines for merge request, delete for webhooks (nmklotas#137) Co-Authored-By: Joseph Petersen <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Get single MR And Add MergeRequestDetail
Add List MR pipelines
Create Merge Request note request