add group labels and issues methods #99
Conversation
- Add some missing issue query parameters - Add `GetAllAsync` endpoint to query issue for project, group or all - Mark `GetAsync` endpoint for issue list (for all and project) as deprecated - Simplify use of issue query options (no need for specific project version) - exists only for backward compatibility
|
Added list group issues endpoint |
Codecov Report
@@ Coverage Diff @@
## master #99 +/- ##
==========================================
+ Coverage 68.83% 72.51% +3.67%
==========================================
Files 135 143 +8
Lines 1980 2059 +79
==========================================
+ Hits 1363 1493 +130
+ Misses 617 566 -51
|
|
Would you mind waiting on me merging this till I have fixed/merged #100 I'd like to finish it this weekend :) |
No problem. I'm on vacations till 7th January 😉 . I will have a look on my GH account, but I have no test system till I'll be back. |
|
@WebDucer integration tests are failing, seems your using project id instead of group id helper :D |
|
@Casz Will check this week. I'll try to get the Docker test environment running on my macOS. |
|
All you need is docker to be installed. The unit test will take care of doing the docker run command |
|
@Casz I had problems to get this running on Windows (in my job) 😄 . Now I will try this at home on Mac. |
|
As part of #100 I fixed the whole docker container setup. Not using a persisted volume and each time you run the unit test you get a fresh instance. So it should run a lot smoother. From my experience on PRs and builds on master the integrations works each time! 😍 |
|
Please do report back if you can get it to work for both Windows and Mac. You just have to run Windows 10 you need to use docker for desktop running in Linux containers mode. |
# Conflicts: # test/GitLabApiClient.Test/Internal/Queries/ProjectIssuesQueryBuilderTest.cs
|
@Casz Fixed tests and integrated the current master. Switched form |
|
Thanks 🙏 |
|
Did you get to test the unit tests on both Windows and Mac? 🤔 |
|
@Casz No, only on macOS, have no Windows at home. Will try it tomorrow on Windows at office (first day after vacations). |
|
@Casz Tested on Windows. It works on my side. All tests are green. |
|
Great, I'll give it a quick review once my laptop is not bitlocked 😭 Soon one of these days I am throwing Linux on this laptop |
There was a problem hiding this comment.
Hmm we properly want to fix the tests using an obsolete method :)
https://github.com/nmklotas/GitLabApiClient/pull/99/checks?check_run_id=375571104
|
@Casz You are right, blaim on me 😉 The deprecated calls are fixed in tests. |
|
I liked the fact that we could see annotated issues right in the pull requests. |
jetersen
changed the title
* nmklotas#97 Add support for group labels * nmklotas#97 Add query options for group label list request * nmklotas#97 Add group issue list endpoint - Add some missing issue query parameters - Add `GetAllAsync` endpoint to query issue for project, group or all - Mark `GetAsync` endpoint for issue list (for all and project) as deprecated - Simplify use of issue query options (no need for specific project version) - exists only for backward compatibility * Fix formatting * nmklotas#97 Small refactorings and documentation * Fix unit test (nmklotas#97) * Fix deprecated calls in tests Co-authored-by: Joseph Petersen <[email protected]>
fixes #97