Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename json->nlohmann for consistency with standard use of 3rd party lib #251

Merged
merged 1 commit into from
Mar 3, 2024

Conversation

phaedon
Copy link
Contributor

@phaedon phaedon commented Jan 14, 2024

Examples on the source repo README, for example https://github.com/nlohmann/json?tab=readme-ov-file#read-json-from-a-file
use #include <nlohmann/json.hpp>

This is also in preparation for adding Bazel support (see https://github.com/phaedon/polyscope/tree/fs-bazel), which requires this pattern for including this json lib
(via https://registry.bazel.build/modules/nlohmann_json rather than through a git submodule)

@nmwsharp nmwsharp merged commit 14556d6 into nmwsharp:master Mar 3, 2024
@nmwsharp
Copy link
Owner

nmwsharp commented Mar 3, 2024

Merged, thanks!

I was initially a little worried about this, because it could be a breaking change if someone is including our copy of nlohmann/json in their application code. But we mark it as a private dependency here https://github.com/nmwsharp/polyscope/blob/master/src/CMakeLists.txt#L337 so I think if anyone is including it regardless it's okay to change the path.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants