Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Build] Import dummy ROS2 publisher #49

Merged
merged 2 commits into from
Oct 22, 2020

Conversation

wooksong
Copy link
Member

@wooksong wooksong commented Oct 22, 2020

Related to nnstreamer/nnstreamer#2728

This is Work-in-Progress to integrate ROS2 code into the existing ROS1 code and make them buildable with both CMake and Colcon. The imported code is from [1] and will be removed.

[1] https://github.com/ros2/examples/tree/eloquent/rclcpp/minimal_publisher

Signed-off-by: Wook Song [email protected]

This is Work-in-Progress to integrate ROS2 code into the existing ROS1
code and make them buildable with both CMake and Colcon. The imported
code is from [1] and will be removed.

[1] https://github.com/ros2/examples/tree/eloquent/rclcpp/minimal_publisher

Signed-off-by: Wook Song <[email protected]>
@taos-ci
Copy link
Collaborator

taos-ci commented Oct 22, 2020

📝 TAOS-CI Version: 1.5.20200925. Thank you for submitting PR #49. Please a submit 1commit/1PR (one commit per one PR) policy to get comments quickly from reviewers. Your PR must pass all verificiation processes of cibot before starting a review process from reviewers. If you are new member to join this project, please read manuals in documentation folder and wiki page. In order to monitor a progress status of your PR in more detail, visit http://nnsuite.mooo.com/.

@taos-ci
Copy link
Collaborator

taos-ci commented Oct 22, 2020

:octocat: cibot: @wooksong, A builder checker could not be completed because one of the checkers is not completed. In order to find out a reason, please go to http://nnsuite.mooo.com/nnstreamer-ros/ci/repo-workers/pr-checker/49-202010221004340.17301988601685-a8b98adc214f49f1d23211eecb2858481a5da105/.

@taos-ci
Copy link
Collaborator

taos-ci commented Oct 22, 2020

:octocat: cibot: @wooksong, A builder checker could not be completed because one of the checkers is not completed. In order to find out a reason, please go to http://nnsuite.mooo.com/nnstreamer-ros/ci/repo-workers/pr-checker/49-202010221017520.90119409561157-cb42a838a9c9fba91bc47328bac7981fcd23091c/.

This patch introduces a virtual class containing common code for
publishing ROS1 and ROS2 topics.

Signed-off-by: Wook Song <[email protected]>
Copy link
Member

@myungjoo myungjoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@myungjoo myungjoo merged commit bf7306a into nnstreamer:main Oct 22, 2020
@wooksong wooksong linked an issue Nov 3, 2020 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ROS2 Support
3 participants