Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Refactor] Move the custom type for error code to the virtual class #52

Merged
merged 1 commit into from
Oct 28, 2020
Merged

[Refactor] Move the custom type for error code to the virtual class #52

merged 1 commit into from
Oct 28, 2020

Conversation

wooksong
Copy link
Member

@wooksong wooksong commented Oct 22, 2020 •
edited
Loading

Related to nnstreamer/nnstreamer#2728

To use the custom data type for error code in both ROS1/ROS2 publishers, this patch moves it to the virtual class.

Signed-off-by: Wook Song [email protected]

@taos-ci
Copy link
Collaborator

taos-ci commented Oct 22, 2020

📝 TAOS-CI Version: 1.5.20200925. Thank you for submitting PR #52. Please a submit 1commit/1PR (one commit per one PR) policy to get comments quickly from reviewers. Your PR must pass all verificiation processes of cibot before starting a review process from reviewers. If you are new member to join this project, please read manuals in documentation folder and wiki page. In order to monitor a progress status of your PR in more detail, visit http://nnsuite.mooo.com/.

@wooksong wooksong force-pushed the make-errcode-public branch from 836be45 to 3e09d4a Compare October 22, 2020 08:15
@wooksong wooksong changed the title [Refactor] Move the custom type for error code to the virtual class [After #50] [Refactor] Move the custom type for error code to the virtual class Oct 22, 2020
@wooksong wooksong force-pushed the make-errcode-public branch from 3e09d4a to d7b4c6f Compare October 27, 2020 06:37
@wooksong wooksong changed the title [After #50] [Refactor] Move the custom type for error code to the virtual class [Refactor] Move the custom type for error code to the virtual class Oct 27, 2020
@taos-ci
Copy link
Collaborator

taos-ci commented Oct 27, 2020

:octocat: cibot: @wooksong, A builder checker could not be completed because one of the checkers is not completed. In order to find out a reason, please go to http://nnsuite.mooo.com/nnstreamer-ros/ci/repo-workers/pr-checker/52-202010271537190.67945790290833-d7b4c6f57c7207328879d33855e679bc04af8d90/.

@wooksong wooksong force-pushed the make-errcode-public branch from d7b4c6f to ef235a1 Compare October 27, 2020 06:56
@taos-ci
Copy link
Collaborator

taos-ci commented Oct 27, 2020

:octocat: cibot: @wooksong, A builder checker could not be completed because one of the checkers is not completed. In order to find out a reason, please go to http://nnsuite.mooo.com/nnstreamer-ros/ci/repo-workers/pr-checker/52-202010271556050.6116349697113-ef235a179d0fd3451e35f4e85be1a137bdba180f/.

@wooksong wooksong force-pushed the make-errcode-public branch from ef235a1 to 03b27d2 Compare October 28, 2020 02:01
@taos-ci
Copy link
Collaborator

taos-ci commented Oct 28, 2020

:octocat: cibot: @wooksong, A builder checker could not be completed because one of the checkers is not completed. In order to find out a reason, please go to http://nnsuite.mooo.com/nnstreamer-ros/ci/repo-workers/pr-checker/52-202010281101200.82213711738586-03b27d21bc84be3821f5495103c8ef805311691f/.

myungjoo
myungjoo approved these changes Oct 28, 2020
View reviewed changes
Copy link
Member

@myungjoo myungjoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@wooksong
[Refactor] Move the custom type for error code to the virtual class
b38452d 
To use the custom data type for error code in both ROS1/ROS2 publishers,
this patch moves it to the virtual class.

Signed-off-by: Wook Song <[email protected]>
@wooksong wooksong force-pushed the make-errcode-public branch from 03b27d2 to b38452d Compare October 28, 2020 05:06
again4you
again4you approved these changes Oct 28, 2020
View reviewed changes
Copy link
Collaborator

@again4you again4you left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@again4you again4you merged commit 2c2d1f9 into nnstreamer:main Oct 28, 2020
@wooksong wooksong deleted the make-errcode-public branch October 28, 2020 06:01
@wooksong wooksong linked an issue Nov 3, 2020 that may be closed by this pull request
ROS2 Support #38
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@again4you again4you again4you approved these changes

@myungjoo myungjoo myungjoo approved these changes

Assignees
No one assigned
Labels
PR/Ready2Go
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

ROS2 Support
4 participants
@wooksong @taos-ci @again4you @myungjoo