Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Ros2/Sink] Implement the 'enable-save-rosbag' feature #53

Merged
merged 1 commit into from
Oct 28, 2020
Merged

[Ros2/Sink] Implement the 'enable-save-rosbag' feature #53

merged 1 commit into from
Oct 28, 2020

Conversation

wooksong
Copy link
Member

@wooksong wooksong commented Oct 27, 2020 •
edited
Loading

Related to nnstreamer/nnstreamer#2728

This patch adds the implementation of the 'enable-save-rosbag' feature which supports recording of the topic tensor_ros_sink in the format of of rosbag2.

Signed-off-by: Wook Song [email protected]

@taos-ci
Copy link
Collaborator

taos-ci commented Oct 27, 2020

📝 TAOS-CI Version: 1.5.20200925. Thank you for submitting PR #53. Please a submit 1commit/1PR (one commit per one PR) policy to get comments quickly from reviewers. Your PR must pass all verificiation processes of cibot before starting a review process from reviewers. If you are new member to join this project, please read manuals in documentation folder and wiki page. In order to monitor a progress status of your PR in more detail, visit http://nnsuite.mooo.com/.

@taos-ci
Copy link
Collaborator

taos-ci commented Oct 27, 2020

:octocat: cibot: @wooksong, A builder checker could not be completed because one of the checkers is not completed. In order to find out a reason, please go to http://nnsuite.mooo.com/nnstreamer-ros/ci/repo-workers/pr-checker/53-202010271900170.21742391586304-adde5b3a3147a5505e8709dd1b7a069c93459f54/.

@wooksong wooksong force-pushed the implement-ros2-sink-bag branch 2 times, most recently from ce78544 to 8d7236d Compare October 28, 2020 06:42
@wooksong
[Ros2/Sink] Implement the 'enable-save-rosbag' feature
7d728f1 
This patch adds the implementation of the 'enable-save-rosbag' feature
which supports recording of the topic tensor_ros_sink in the format of
of rosbag2.

Signed-off-by: Wook Song <[email protected]>
@wooksong wooksong force-pushed the implement-ros2-sink-bag branch from 8d7236d to 7d728f1 Compare October 28, 2020 06:55
again4you
again4you approved these changes Oct 28, 2020
View reviewed changes
Copy link
Collaborator

@again4you again4you left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@again4you again4you merged commit 5f0801b into nnstreamer:main Oct 28, 2020
@wooksong wooksong deleted the implement-ros2-sink-bag branch October 28, 2020 07:35
@wooksong wooksong linked an issue Nov 3, 2020 that may be closed by this pull request
ROS2 Support #38
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@again4you again4you again4you approved these changes

@myungjoo myungjoo myungjoo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

ROS2 Support
4 participants
@wooksong @taos-ci @again4you @myungjoo