Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Ros/Src] Refactor tensor_ros_src for ROS1/RosCpp #55

Merged
merged 2 commits into from
Nov 6, 2020
Merged

[Ros/Src] Refactor tensor_ros_src for ROS1/RosCpp #55

merged 2 commits into from
Nov 6, 2020

Conversation

wooksong
Copy link
Member

@wooksong wooksong commented Nov 2, 2020 •
edited
Loading

Related to nnstreamer/nnstreamer#2728

This patch revises the implementation of tensor_ros_src for ROS1 (ROSCPP) as follows:

  • Moved the common code that can be used for both ROS1 and ROS2 to a virtual class, NnsRosSubscriber
  • Instead of tensor_ros_listener.hpp, the header which is generated from the ROS message definition is used.
  • Removed duplicate code in the CMake script.

Signed-off-by: Wook Song [email protected]

@taos-ci
Copy link
Collaborator

taos-ci commented Nov 2, 2020

📝 TAOS-CI Version: 1.5.20200925. Thank you for submitting PR #55. Please a submit 1commit/1PR (one commit per one PR) policy to get comments quickly from reviewers. Your PR must pass all verificiation processes of cibot before starting a review process from reviewers. If you are new member to join this project, please read manuals in documentation folder and wiki page. In order to monitor a progress status of your PR in more detail, visit http://nnsuite.mooo.com/.

@taos-ci
Copy link
Collaborator

taos-ci commented Nov 2, 2020

:octocat: cibot: @wooksong, A builder checker could not be completed because one of the checkers is not completed. In order to find out a reason, please go to http://nnsuite.mooo.com/nnstreamer-ros/ci/repo-workers/pr-checker/55-202011021936570.57552599906921-77313794f294a3e7df3e6bb7f8e07dda667dcd06/.

@wooksong
[Ros/Src] Refactor tensor_ros_src for ROS1/RosCpp
d84144b 
This patch revises the implementation of tensor_ros_src for ROS1
(ROSCPP) as follows:
- Moved the common code that can be used for both ROS1 and ROS2 to a
virtual class, NnsRosSubscriber
- Instead of tensor_ros_listener.hpp, the header which is generated from
the ROS message definition is used.
- Removed duplicate code in the CMake script.

Signed-off-by: Wook Song <[email protected]>
@wooksong wooksong force-pushed the revise-tensor_ros_src branch from 7731379 to d84144b Compare November 3, 2020 01:56
@taos-ci
Copy link
Collaborator

taos-ci commented Nov 3, 2020

:octocat: cibot: @wooksong, A builder checker could not be completed because one of the checkers is not completed. In order to find out a reason, please go to http://nnsuite.mooo.com/nnstreamer-ros/ci/repo-workers/pr-checker/55-202011031103220.6418399810791-5f9f64818c4f2a449a606cc7059285dde1078174/.

@wooksong wooksong force-pushed the revise-tensor_ros_src branch from 5f9f648 to b112fcc Compare November 3, 2020 02:13
@wooksong wooksong linked an issue Nov 3, 2020 that may be closed by this pull request
ROS2 Support #38
Closed
@wooksong
[Tests/Src] Revise test cases according to the changes in tensor_ros_src
6f0f7a9 
This patch revises test cases according to the changes in
tensor_ros_src.

Signed-off-by: Wook Song <[email protected]>
@wooksong wooksong force-pushed the revise-tensor_ros_src branch from b112fcc to 6f0f7a9 Compare November 3, 2020 07:22
again4you
again4you approved these changes Nov 3, 2020
View reviewed changes
Copy link
Collaborator

@again4you again4you left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@wooksong wooksong merged commit 8b88b40 into nnstreamer:main Nov 6, 2020
@wooksong wooksong deleted the revise-tensor_ros_src branch November 6, 2020 02:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@again4you again4you again4you approved these changes

@myungjoo myungjoo Awaiting requested review from myungjoo myungjoo is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

ROS2 Support
3 participants
@wooksong @taos-ci @again4you