Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Ros2/Src] Add a draft implementation of tensor_ros_src for ROS2 #56

Merged
merged 1 commit into from
Nov 9, 2020

Conversation

wooksong
Copy link
Member

@wooksong wooksong commented Nov 3, 2020

Related to nnstreamer/nnstreamer#2728

This patch adds a draft implementation of tensor_ros_src using the RclCpp library from ROS2 (eloquent). Currently, it is possible to
receive data from a given topic and generate the tensor stream based on such data. More testings and code refactoring remain to be done.

Signed-off-by: Wook Song [email protected]

@taos-ci
Copy link
Collaborator

taos-ci commented Nov 3, 2020

📝 TAOS-CI Version: 1.5.20200925. Thank you for submitting PR #56. Please a submit 1commit/1PR (one commit per one PR) policy to get comments quickly from reviewers. Your PR must pass all verificiation processes of cibot before starting a review process from reviewers. If you are new member to join this project, please read manuals in documentation folder and wiki page. In order to monitor a progress status of your PR in more detail, visit http://nnsuite.mooo.com/.

@wooksong wooksong changed the title [Ros2/Src] Add a draft implementation of tensor_ros_src for ROS2 [After #55] [Ros2/Src] Add a draft implementation of tensor_ros_src for ROS2 Nov 3, 2020
@wooksong wooksong linked an issue Nov 3, 2020 that may be closed by this pull request
@wooksong wooksong force-pushed the wip-implement-nns-ros2-sub branch from 1c034a3 to 2d8a3b8 Compare November 6, 2020 02:34
@wooksong wooksong changed the title [After #55] [Ros2/Src] Add a draft implementation of tensor_ros_src for ROS2 [Ros2/Src] Add a draft implementation of tensor_ros_src for ROS2 Nov 6, 2020
Copy link
Collaborator

@again4you again4you left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

This patch adds a draft implementation of tensor_ros_src using the
RclCpp library from ROS2 (eloquent). Currently, it is possible to
receive data from a given topic and generate the tensor stream based on
such data. More testings and code refactoring remain to be done.

Signed-off-by: Wook Song <[email protected]>
@wooksong wooksong force-pushed the wip-implement-nns-ros2-sub branch from 2d8a3b8 to 94a4e16 Compare November 6, 2020 09:41
@wooksong wooksong merged commit ab3b572 into nnstreamer:main Nov 9, 2020
@wooksong wooksong deleted the wip-implement-nns-ros2-sub branch November 9, 2020 04:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ROS2 Support
3 participants