Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Tests] Modify test cases to use them for ROS/ROS2 in common #58

Merged
merged 3 commits into from
Nov 9, 2020

Conversation

wooksong
Copy link
Member

@wooksong wooksong commented Nov 9, 2020

Related to nnstreamer/nnstreamer#2728 and #38

This patch modifies GTEST-based test cases to use them for both ROS and ROS2 in common.

Signed-off-by: Wook Song [email protected]

This is a trivial patch to clean up the CMake scripts by removing
duplicate codes.

Signed-off-by: Wook Song <[email protected]>
This patch adds a mode to enable build options for code instrumentation
so that coverage analysis is supported using lcov.

Signed-off-by: Wook Song <[email protected]>
@taos-ci
Copy link
Collaborator

taos-ci commented Nov 9, 2020

📝 TAOS-CI Version: 1.5.20200925. Thank you for submitting PR #58. Please a submit 1commit/1PR (one commit per one PR) policy to get comments quickly from reviewers. Your PR must pass all verificiation processes of cibot before starting a review process from reviewers. If you are new member to join this project, please read manuals in documentation folder and wiki page. In order to monitor a progress status of your PR in more detail, visit http://nnsuite.mooo.com/.

@taos-ci
Copy link
Collaborator

taos-ci commented Nov 9, 2020

:octocat: cibot: @wooksong, A builder checker could not be completed because one of the checkers is not completed. In order to find out a reason, please go to http://nnsuite.mooo.com/nnstreamer-ros/ci/repo-workers/pr-checker/58-202011091625440.5287721157074-9a166a7654dcd6e8ea354e413b26e99a0ff2ff73/.

This patch modifies GTEST-based test cases to use them for both
ROS and ROS2 in common.

Signed-off-by: Wook Song <[email protected]>
Copy link
Collaborator

@again4you again4you left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@myungjoo myungjoo merged commit dc32cf2 into nnstreamer:main Nov 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants