CLPlatform self-assignment

[piotrrak]

Hello,

Noticed this issue by reviewing the code.

That's surely a bug:

nntrainer/nntrainer/opencl/opencl_context_manager.cpp

Line 156 in 89e8b7c

platform_id_ = platform_id_;

platform_ = platform_;
Results in not initializing platform_ member field with platforms[0] as I suppose was intended.

Currently clang build doesn't work and I am planning to enable it for the project (at-very least for x86-64).
The reason is that clang has '-Wself-assignment' option and will be able catch typos like those.

I have not learned how to run test suit for OpenCL yet. Does the CI run any of the OpenCL tests to degree I can put my faith into?

Cheers
/P

[taos-ci]

cibot: Thank you for posting issue #2763. The person in charge will reply soon.

[DonghakPark]

Hello @piotrrak

in our github CI, you can see the build option at .github/workflows/ubuntu_clean_meson_build.yml

        meson \
          --buildtype=plain \
          --prefix=/usr \
          --sysconfdir=/etc \
          --libdir=lib/x86_64-linux-gnu \
          --bindir=lib/nntrainer/bin \
          --includedir=include \
          -Dinstall-app=true \
          -Dreduce-tolerance=false \
          -Denable-debug=true \
          -Dml-api-support=enabled \
          -Denable-nnstreamer-tensor-filter=enabled \
          -Denable-nnstreamer-tensor-trainer=enabled \
          -Denable-nnstreamer-backbone=true \
          -Dcapi-ml-common-actual=capi-ml-common \
          -Dcapi-ml-inference-actual=capi-ml-inference \
          -Denable-capi=enabled \
          ${{ matrix.meson_options }} \

It seems that the 'enable-opencl' build option is missing from the currently running CI, indicating that testing may not be taking place in GitAction.

If you have tested it locally without any issues, I will update the CI.

[github-actions]

This issue is stale because it has been open 90 days with no activity. Remove stale label or comment or this will be closed in 3 days.

[myungjoo]

@DonghakPark Don't you need to do

-  platform_id_ = platform_id_;
+  this->platform_id_ = platform_id_;