Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleanup and Model Improvements #11

Open
wants to merge 142 commits into
base: master
Choose a base branch
from
Open

Cleanup and Model Improvements #11

wants to merge 142 commits into from

Conversation

sshleifer
Copy link
Contributor

@sshleifer sshleifer commented Dec 17, 2019

Changes that improve performance to 3.00 - 3.02 test MAE:

  • Learning Rate Decay (default =.97)
  • skip connection if cat_feat_gc=True
  • default nhid=40 (instead of 32)
  • default clip=3 (instead of 5)
  • replace 0s with mean in StandardScaler

Changes that don't affect performance:

  • only save one checkpoint
  • add early stopping
  • simplification of do_graph_conv command line args
  • share parser code between train.py and test.py
  • misc renamings
  • store metrics in pandas and write them to disk nicely
  • no expid --save specifies a directory.
  • save args to --save for reproducibility
  • train.py skip batches where all targets are 0: they will certainly have 0 loss.
  • misc renamings
  • check in best_model.pth. Dont need to retrain to inspect.
  • calculate all three metrics in one function instead of 3.

Metrics:
baseline: 3.00 - 3.02
finetuning: 2.99-3.00

Paper has more details on experiments that didn't work: http://arxiv.org/abs/1912.07390

@sshleifer sshleifer marked this pull request as ready for review December 17, 2019 18:29
@sshleifer sshleifer changed the title Pr Cleanup and Model Improvements Dec 17, 2019
@nnzhan
Copy link
Owner

nnzhan commented Dec 18, 2019

Dear all

Thanks for your great contribution. I am impressed by your wonderful efforts to improve Graph Wavenet. I will review the codes as soon as possible.

Bests
Zonghan

@nnzhan
Copy link
Owner

nnzhan commented Dec 22, 2019

Dear all,

I think you have done a very good job. To respect your contribution mostly, I would highly recommend to keep your own repository and not merge into the project. I will instead add a link referring to your repo.

Best regards,
Zonghan

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants