-
Notifications
You must be signed in to change notification settings - Fork 203
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cleanup and Model Improvements #11
base: master
Are you sure you want to change the base?
Conversation
Cheaper metric calc, cleanup
Dear all Thanks for your great contribution. I am impressed by your wonderful efforts to improve Graph Wavenet. I will review the codes as soon as possible. Bests |
Dear all, I think you have done a very good job. To respect your contribution mostly, I would highly recommend to keep your own repository and not merge into the project. I will instead add a link referring to your repo. Best regards, |
Changes that improve performance to 3.00 - 3.02 test MAE:
cat_feat_gc=True
StandardScaler
Changes that don't affect performance:
--save
specifies a directory.--save
for reproducibilitytrain.py
skip batches where all targets are 0: they will certainly have 0 loss.best_model.pth
. Dont need to retrain to inspect.Metrics:
baseline: 3.00 - 3.02
finetuning: 2.99-3.00
Paper has more details on experiments that didn't work: http://arxiv.org/abs/1912.07390