Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

* Lexer.has: return true for error token, if any (fixes #76). #77

Merged
merged 2 commits into from
Oct 5, 2017

Conversation

JoshuaGrams
Copy link
Contributor

No description provided.

@tjvr
Copy link
Collaborator

tjvr commented Sep 28, 2017

Thanks for spotting this!

Please can you add a test for this? :-)

@JoshuaGrams
Copy link
Contributor Author

Ooops. Added tests.

@tjvr tjvr self-requested a review October 5, 2017 15:23
Copy link
Collaborator

@tjvr tjvr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great! Thanks :D

@tjvr tjvr merged commit f5572c9 into no-context:master Oct 5, 2017
@tjvr
Copy link
Collaborator

tjvr commented Oct 5, 2017

I just realised you're the guy who wrote Pint-sized Earley Parser :D I really liked that article, wrote a couple of (unshared) parsers based on your ideas, and indeed I'm slowly trying to work them into Nearley... :-)

@JoshuaGrams
Copy link
Contributor Author

Heh. Thanks. Not my ideas, though. That's almost straight out of Elizabeth Scott's paper. Loup Vaillant (Earley Parsing Explained) said that he "completely failed to understand" her paper. He presents a more complicated (and slower?) algorithm to construct the parse trees. We had a conversation on the FoNC mailing list and were just talking past each other, so I wrote an implementation to demonstrate how simple it actually is once you strip away all the obfuscating formalisms. Still not sure I actually addressed his objections, but I had fun writing it. :-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants