update `stormevents` API to `>=1.3.0` #79

ghost · 2022-03-14T14:43:13Z

use new method names and ATCF reading functionality from stormevents, and apply new improved CI workflow that fixes running tests

* use new `StormEvents` API * install wheel first * install PROJ * linting step * build PROJ * build PROJ * build PROJ * build PROJ * fix workflows * fix test files * skip test that hangs * fix original file test * change original track handling (write to file first and then read from threads) * update workflow names * we no longer need to write pickles to a temporary file if the track object already exists in memory * revert import change

…e_stormevents # Conflicts: # ensembleperturbation/perturbation/atcf.py # setup.cfg

codecov-commenter · 2022-03-14T14:51:49Z

Codecov Report

❗ No coverage uploaded for pull request base (feature/regression_selection@7912f5c). Click here to learn what that means.
The diff coverage is n/a.

@@                       Coverage Diff                       @@
##             feature/regression_selection      #79   +/-   ##
===============================================================
  Coverage                                ?   31.12%           
===============================================================
  Files                                   ?       26           
  Lines                                   ?     2940           
  Branches                                ?        0           
===============================================================
  Hits                                    ?      915           
  Misses                                  ?     2025           
  Partials                                ?        0

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7912f5c...4c86d52. Read the comment docs.

ghost

here are the major changes that are applied with the new stormevents API, as well as the new build and testing workflow

ghost · 2022-03-14T14:45:00Z

.github/actions/setup-proj/action.yml

@@ -0,0 +1,43 @@
+name: 'Setup PROJ'


this fixes the GitHub Actions CI tests by setting up PROJ so that cartopy can be built (and cached) correctly within the container

ghost · 2022-03-14T14:46:56Z

ensembleperturbation/plotting/nodes.py

@@ -215,7 +215,7 @@ def plot_node_map(
    if storm is not None:
        if not isinstance(storm, VortexTrack):
            try:
-                storm = VortexTrack.from_fort22(storm)
+                storm = VortexTrack.from_file(storm)


VortexTrack.from_fort22() and VortexTrack.from_atcf_file() were merged into VortexTrack.from_file()

ghost · 2022-03-14T14:47:34Z

setup.cfg

@@ -32,7 +32,7 @@ install_requires =
    requests
    shapely
    scikit-learn
-    stormevents == 1.2.5
+    stormevents >= 1.3.1


this is where pip install . gets the dependencies from

ghost · 2022-03-14T14:48:38Z

tests/data/reference/test_monovariate_besttrack_ensemble/original.22

the reference files for the tests are updated to include the additional ATCF fields that came from the original file

ghost · 2022-03-14T14:50:33Z

tests/test_track_ensemble.py

@@ -23,7 +24,7 @@ def test_monovariate_besttrack_ensemble():
        output_directory.mkdir(parents=True, exist_ok=True)

    perturber = VortexPerturber(
-        storm='al062018', start_date='20180911', end_date=None, file_deck=ATCF_FileDeck.b,
+        storm='al062018', start_date='20180911', end_date=None, file_deck='b',


this allows the file deck input to be a single letter, or alternatively the name (BEST, OFCL, etc.), along with the option to directly call the enum value

ghost · 2022-03-14T14:52:10Z

tests/test_track_ensemble.py

+    pandas.testing.assert_frame_equal(original_track_1.data[comparison_fields], original_data)
+    pandas.testing.assert_frame_equal(original_track_2.data[comparison_fields], original_data)
+    pandas.testing.assert_frame_equal(original_track_3.data[comparison_fields], original_data)


this test is now updated to use the output original.22 instead of relying on a reference file. This should test for regression of this bug more thoroughly

WPringle · 2022-03-16T17:47:51Z

@zacharyburnettNOAA Can make sure the tests are all working as we upgrade the version, and we need to work out how to better treat the advisories (from the a deck) of the storms. All the advisories are squashed together but we need to work out a way to separate them for each individual forecast.

ghost · 2022-03-16T17:53:38Z

@zacharyburnettNOAA Can make sure the tests are all working as we upgrade the version, and we need to work out how to better treat the advisories (from the a deck) of the storms. All the advisories are squashed together but we need to work out a way to separate them for each individual forecast.

Ok, that's easily done by iterating over the 'record_type' field, which is 'BEST', 'OFCL', 'CARQ', etc.. You can do that in pandas by using track.data.groupby('record_type)`

But you are right, we need to add native handling of the record types. I added functionality for that in the .linestrings method (to separate into multiple line strings for each advisory track) but I don't think it is elsewhere in the code

zacharyburnett added 4 commits March 10, 2022 17:45

fix RTD config

a959078

Merge remote-tracking branch 'origin/release/v0.9.x' into merge/updat…

a66983d

…e_stormevents # Conflicts: # ensembleperturbation/perturbation/atcf.py # setup.cfg

formatting with oitnb

e531270

ghost added the enhancement New feature or request label Mar 14, 2022

ghost requested a review from WPringle March 14, 2022 14:43

ghost self-assigned this Mar 14, 2022

ghost commented Mar 14, 2022

View reviewed changes

ghost marked this pull request as ready for review March 14, 2022 14:53

ghost mentioned this pull request Mar 14, 2022

scikit linear regression_model, log-scale depths, wet-dry node handling #74

Closed

zacharyburnett added 2 commits March 15, 2022 16:47

better handling of input fort.22 file

f1ce14b

found an extranneous usage of .from_fort22()

4c86d52

ghost merged commit 9ce16db into feature/regression_selection Mar 16, 2022

ghost deleted the merge/update_stormevents branch March 16, 2022 18:39

This pull request was closed.

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

update `stormevents` API to `>=1.3.0` #79

update `stormevents` API to `>=1.3.0` #79

ghost commented Mar 14, 2022 •

edited by ghost

Loading

codecov-commenter commented Mar 14, 2022 •

edited

Loading

ghost left a comment •

edited by ghost

Loading

ghost Mar 14, 2022

ghost Mar 14, 2022

ghost Mar 14, 2022

ghost Mar 14, 2022

ghost Mar 14, 2022

ghost Mar 14, 2022

WPringle commented Mar 16, 2022 •

edited

Loading

ghost commented Mar 16, 2022 •

edited by ghost

Loading

update stormevents API to >=1.3.0 #79

update stormevents API to >=1.3.0 #79

Conversation

ghost commented Mar 14, 2022 • edited by ghost Loading

codecov-commenter commented Mar 14, 2022 • edited Loading

Codecov Report

ghost left a comment • edited by ghost Loading

Choose a reason for hiding this comment

ghost Mar 14, 2022

Choose a reason for hiding this comment

ghost Mar 14, 2022

Choose a reason for hiding this comment

ghost Mar 14, 2022

Choose a reason for hiding this comment

ghost Mar 14, 2022

Choose a reason for hiding this comment

ghost Mar 14, 2022

Choose a reason for hiding this comment

ghost Mar 14, 2022

Choose a reason for hiding this comment

WPringle commented Mar 16, 2022 • edited Loading

ghost commented Mar 16, 2022 • edited by ghost Loading

update `stormevents` API to `>=1.3.0` #79

update `stormevents` API to `>=1.3.0` #79

ghost commented Mar 14, 2022 •

edited by ghost

Loading

codecov-commenter commented Mar 14, 2022 •

edited

Loading

ghost left a comment •

edited by ghost

Loading

WPringle commented Mar 16, 2022 •

edited

Loading

ghost commented Mar 16, 2022 •

edited by ghost

Loading