Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SDVX Import Suggested Fixes #37

Merged
merged 11 commits into from
Jul 13, 2020
Merged

SDVX Import Suggested Fixes #37

merged 11 commits into from
Jul 13, 2020

Conversation

vlnguyen
Copy link
Collaborator

@vlnguyen vlnguyen commented Jul 12, 2020 •
edited
Loading

  • Distinguish the different difficulty classes that exist within the INFINITE difficulty class, (INF, GRV, HVN, VVD).
  • Change difficulty class colors to be more vibrant and suggested a default difficulty range of 16-19 on load.
  • Implement chart-level jackets, and added functionality to SDVX music_db.xml imports to determine the jacket filenames.
  • Uploaded the SDVX song jackets.

noahm
noahm reviewed Jul 13, 2020
View reviewed changes
Copy link
Owner

@noahm noahm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is great! I can merge as-is and address these points myself or let you touch it up if you want to for the fun of it.

scripts/import-sdvx.js Outdated Show resolved Hide resolved
scripts/import-sdvx.js Outdated Show resolved Hide resolved
scripts/import-sdvx.js Show resolved Hide resolved
scripts/import-sdvx.js Show resolved Hide resolved
@noahm noahm merged commit 5621a12 into noahm:sdvx-import Jul 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@noahm noahm noahm left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@vlnguyen @noahm