fix: Fix config file handle closing and run cross platform unit tests #639
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nieomylnieja
requested review from
skrolikiewicz and
daniel-zelazny
as code owners
nieomylnieja
changed the title
nieomylnieja
changed the title
nieomylnieja
changed the title
daniel-zelazny
approved these changes
Feb 5, 2025
nieomylnieja
added a commit
to nobl9/sloctl
that referenced
this pull request
Feb 5, 2025
## Motivation Currently, whenever modifying the `config.toml` file on Windows using `sloctl config` commands an error arises: > Error: rename C:\Users\mh\.config\nobl9\config.toml3389036250 C:\Users\mh\.config\nobl9\config.toml: The process cannot access the file because it is being used by another process. The issue comes from Nobl9 SDK and is fixed by nobl9/nobl9-go#639. ## Related changes - nobl9/nobl9-go#639 ## Testing Tested on Windows 11 23H2 run inside Virtual Box.  ## Release Notes `sloctl config` commands which modify _config.toml_ should now work on Windows.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
The main reason for this PR is to fix config file writing on Windows, because we were not properly closing the file handle before renaming it, this cause an error on Windows, stating that file is already used by another process.
Summary
In order to better support Linux, MacOS and Windows usages we should run the unit tests on each of them.
Release Notes
sdk.FileConfigoperations which attempt to save the config file should now operate on Windows without any issues.