-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: backport module hash query #3
feat: backport module hash query #3
Conversation
Co-authored-by: Facundo Medica <[email protected]> Co-authored-by: Marko <[email protected]>
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me! Just a small import cleanup
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks amazing! Thanks so much for picking this up.
Left one question, and agree with Luca's comment on cleaning up imports 👍🏻
server/module_hash.go
Outdated
}) | ||
|
||
// Create a new CommitInfo with the modified StoreInfos. | ||
commitInfoForHeight = &types.CommitInfo{ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@spoo-bar Random question, what is the missing timestamp here? Is this when the store was updated, or is this equivalent to the block height?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Its the block timestamp. Added for context in historical queries.
Description
Cherrypicking: cosmos#20779
Targeting v0.45.x-send-restrictions as took that as base, but will change to a better target
Diffs:
CommitInfo
struct in sdk 45. https://github.com/cosmos/cosmos-sdk/blob/61dd9e33854f8eb7eaf1ef0a907e005996117bd7/server/module_hash.go#L97