Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: backport module hash query #3

Merged
merged 2 commits into from
Aug 13, 2024

Conversation

spoo-bar
Copy link

Description

Cherrypicking: cosmos#20779

Targeting v0.45.x-send-restrictions as took that as base, but will change to a better target

Diffs:

  1. Timestamp not included in the commitinfo as its not part of the CommitInfo struct in sdk 45. https://github.com/cosmos/cosmos-sdk/blob/61dd9e33854f8eb7eaf1ef0a907e005996117bd7/server/module_hash.go#L97

@spoo-bar spoo-bar requested review from boojamya and johnletey August 12, 2024 08:25
Copy link

coderabbitai bot commented Aug 12, 2024

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share
Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@johnletey johnletey requested review from g-luca and removed request for boojamya August 12, 2024 08:44
@spoo-bar spoo-bar marked this pull request as ready for review August 12, 2024 08:46
Copy link

@g-luca g-luca left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! Just a small import cleanup

server/module_hash.go Outdated Show resolved Hide resolved
Copy link
Member

@johnletey johnletey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks amazing! Thanks so much for picking this up.

Left one question, and agree with Luca's comment on cleaning up imports 👍🏻

})

// Create a new CommitInfo with the modified StoreInfos.
commitInfoForHeight = &types.CommitInfo{
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@spoo-bar Random question, what is the missing timestamp here? Is this when the store was updated, or is this equivalent to the block height?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Its the block timestamp. Added for context in historical queries.

@johnletey johnletey changed the title feat: cherrypicking module hash by query from the cosmos-sdk latest feat: module hash by query Aug 12, 2024
@johnletey johnletey changed the title feat: module hash by query feat: backport module hash by query Aug 12, 2024
@johnletey johnletey changed the title feat: backport module hash by query feat: backport module hash query Aug 12, 2024
@johnletey johnletey merged commit 1a61bab into v0.45.x-send-restrictions Aug 13, 2024
1 check passed
@johnletey johnletey deleted the spoorthi/module-hash-by-query branch August 13, 2024 14:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants