This repository has been archived by the owner on Apr 11, 2022. It is now read-only.
Add more test #28
Merged
Add more test #28
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This allow to test `v fmt` and `v build`
because it was always triggered in the pull_request event.
…vlang-action into shiipou-patch-1
alexesprit
reviewed
Aug 17, 2020
| - name: Test V is present | ||
| run: v version | ||
|
|
||
| - name: Test V fmt |
There was a problem hiding this comment.
Why do we need to test V commands here? It's enough to run v version and ${{ steps.v.outputs.v_home }}/v version to make sure V executable is visible.
There was a problem hiding this comment.
Because I've got one people where the command v fmt -verify does not work when using the action.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allow to test
v fmtandv build