Update and Undo Breaking Changes #9
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
After tabbing to a selectr element, pressing enter wouldn't activate the selected state to display the selectr container. After dismissing the dialog (e.g. via pressing enter), the tab focus was lost thus starting you back over at the top of the document (making using keyboard only navigation painful).
Odd Search Results
Two minor changes
This fixes a bug, where no items were selected during live search if you use optgroups. This can also be verified on the original demo page.
The original approach to get the first child from live search dropdown in Selectr.prototype.search on line 1926 was to use firstElementChild.
But this returns the pseudo optgroup li item and not a real result. This can be fixed by using querySelector(".selectr-option:not(.excluded)").
Fixes various errors when moving through search results with arrow keys if using optgroups.
Fixes navigation in optgroup search results
Bugfix for missing index on search with optgroups
Set tabindex to 0 or "un-ordered"
Add better keyboard support
Previously checked when an existing option matched any substring of the setValue option. This meant doing setValue("Book Review 2016") would match "Book" "Review", "2016" "Book Review" and "Book Review 2016". Now it treats each tag as a whole unit and will only match "Book Review 2016".
Update selectr.js
…eyword search results in "no results"
Adds noResults property to prevent onChange event from firing when k…
improved bugfix for the tabSeperators
sync with base
Added check for data length before default selecting first element
Mobius1#93 defaultSelected not working as expected
Checking for items before default selecting first item (bugfix)
fix accessibility
New param for config and clear last item
Update selectr.js
…resents an xss vulnerability)
…6851 Close XSS Vector
More XSS Fixes
adrian-enspired
changed the title
|
Mobius1#122 was just merged, so we should pull upstream and use that instead : ) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Brings our production branch up to date with latest upstream release; removes upstream changes that were dumb and broke things.
fixes https://nexcess.atlassian.net/browse/NSD-16851