Fix Node compatibility error for Node @ 14 #62
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
An incorrect setting for the `engines` filed in the project's `package.json` is causing install errors for major versions of node above v10, such as the following: ```bash error [email protected]: The engine "node" is incompatible with this module. Expected version "^10.17.0" . Got "14.10.0" ``` After running into this error I tried updating both node and yarn to the latest versions (`14.11.0` and `1.22.5` respectively) and continued to get an incompatible module error. It would appear that the or condition isn't being checked, so while `^14.10.0` should satisfy `>=12.3.0`, semver isn't checking against that condition and fast failing on `^10.17.0` instead, limiting the major version range. A simpler condition should satisfy the minimum version requirement, such as `>=10.17.0` as proposed in this PR.
Codecov Report
@@ Coverage Diff @@
## master #62 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 2 2
Lines 231 231
Branches 36 36
=========================================
Hits 231 231 Continue to review full report at Codecov.
|
|
Also worth noting, I'm running Windows 10. Saw that the tests were being run for node@^14 on ubuntu but only node@^12 on windows. Don't know if that would have caught this problem before. |
Saeris
changed the title
tinovyatkin
approved these changes
Dec 20, 2020
|
@Richienb this needs to be released because currently there is no way to install this package on node@14 neither install |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
An incorrect setting for the
enginesfiled in the project'spackage.jsonis causing install errors for major versions of node above v10, such as the following:After running into this error I tried updating both node and yarn to the latest versions (
14.11.0and1.22.5respectively) and continued to get an incompatible module error.It would appear that the or condition isn't being checked, so while
^14.10.0should satisfy>=12.3.0, semver isn't checking against that condition and fast failing on^10.17.0instead, limiting the major version range. Swapping the order of this semver rule may solve for this error.Additional CI tests may be required, but I'm unsure how to properly configure those.