-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Created a File Class #97
Conversation
Codecov Report
@@ Coverage Diff @@
## master #97 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 2 3 +1
Lines 289 350 +61
Branches 44 51 +7
=========================================
+ Hits 289 350 +61
Continue to review full report at Codecov.
|
...not worth the effort
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
I got two packages that would very much need a File class, I know @octet-stream could need one as well. I added it as a separate file (
file.js
) that also extends the Blob class.Therefore i have also added the
fileFrom
andfileFromAsync
methods tofrom.js
as wellI also added the option to pass in a mimetype in in all 4 methods so it can set the
type
on the blob/file so it dosen't have to be wrapped again in a new blob or filecloses #91
I also took the opportunity to extract the DOMException from NodeJS itself and removed the dependency on DOMException package
closes #96
Also updated all dependencies and fixed the new lint rules by xo
closes #95