Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: refactor with typescript #117

Merged
merged 2 commits into from
Oct 11, 2023
Merged

Conversation

liuhanqu
Copy link
Contributor

@liuhanqu liuhanqu commented Oct 10, 2023

BREAKING CHANGE: Drop Node.js < 16 support

closes #116

@socket-security
Copy link

socket-security bot commented Oct 10, 2023

New, updated, and removed dependencies detected. Learn more about Socket for GitHub ↗︎

Packages Version New capabilities Transitives Size Publisher
tshy-after 1.0.0 None +0 5.02 kB fengmk2
git-contributor 2.1.5 shell, environment +28 2.42 MB xudafeng
mocha 10.2.0 filesystem, environment +38 4.15 MB juergba
ts-node 10.9.1 filesystem, environment +15 5.38 MB cspotcode
@types/node 20.8.4 None +1 4 MB types
egg-bin 6.5.2 eval, network, environment +179 89.4 MB fengmk2
tshy 1.2.2 filesystem +7 703 kB isaacs
get-ready 2.0.1...3.1.0 None +0/-0 18.8 kB fengmk2

🚮 Removed packages: [email protected], [email protected]

@codecov
Copy link

codecov bot commented Oct 10, 2023

Codecov Report

Merging #117 (cd2f99e) into master (f5bfa41) will increase coverage by 1.36%.
Report is 1 commits behind head on master.
The diff coverage is 100.00%.

@@             Coverage Diff             @@
##           master      #117      +/-   ##
===========================================
+ Coverage   98.63%   100.00%   +1.36%     
===========================================
  Files           1         1              
  Lines         146       147       +1     
  Branches       28        29       +1     
===========================================
+ Hits          144       147       +3     
+ Misses          2         0       -2     
Files Coverage Δ
src/index.ts 100.00% <100.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

tsconfig.json Outdated Show resolved Hide resolved
@fengmk2 fengmk2 self-assigned this Oct 10, 2023
src/index.ts Outdated Show resolved Hide resolved
@fengmk2 fengmk2 merged commit 7193ec1 into node-modules:master Oct 11, 2023
@fengmk2
Copy link
Member

fengmk2 commented Oct 11, 2023

@liuhanqu Nice job!

fengmk2 pushed a commit that referenced this pull request Oct 11, 2023
[skip ci]

## [4.0.0](v3.0.0...v4.0.0) (2023-10-11)

### ⚠ BREAKING CHANGES

* Drop Node.js < 16 support

closes #116

part of eggjs/egg#5257

### Features

* refactor with typescript to support esm and cjs both ([#117](#117)) ([7193ec1](7193ec1))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

need to refactor with typescript ?
2 participants