Ssrf #279
Merged
Ssrf #279
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dead-horse
force-pushed
the
ssrf
branch
2 times, most recently
from
ca4b308 to
f5e86e0
Compare
dead-horse
commented
Mar 24, 2018
lib/urllib.js
Outdated
| return done(err); | ||
| } | ||
| function handleRequestEvents(req) { | ||
| if (timing) { |
|
0.10 的测试去掉了，muk 都用不了... |
fengmk2
reviewed
Mar 26, 2018
fengmk2
reviewed
Mar 26, 2018
lib/urllib.js
Outdated
| @@ -243,6 +246,23 @@ exports.requestWithCallback = function requestWithCallback(url, args, callback) | |||
| agent = proxyTunnelAgent; | |||
| } | |||
|
|
|||
| var _lookup = args.lookup || dns.lookup; | |||
There was a problem hiding this comment.
没有设置 args.checkAddress 的时候，能否不要去默认设置 lookup 为 dns.lookup？
fengmk2
reviewed
Mar 26, 2018
lib/urllib.js
Outdated
| try { | ||
| req = httplib.request(options, onResponse); | ||
| req.requestId = reqId; | ||
| handleRequestEvents(req); |
|
改掉了，再看看 |
fengmk2
approved these changes
Mar 26, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.