Fixes #180: Added additional empty cert validation to SAML initialize

node-saml · Oct 23, 2018 · 6f127f5 · 6f127f5
1 parent 00ea774
commit 6f127f5
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 19 deletions.
diff --git a/lib/passport-saml/saml.js b/lib/passport-saml/saml.js
@@ -24,6 +24,10 @@ SAML.prototype.initialize = function (options) {
     options = {};
   }
 
+  if (options.hasOwnProperty('cert') && !options.cert) {
+    throw new Error('Invalid property: cert must not be empty');
+  }
+
   if (!options.path) {
     options.path = '/saml/consume';
   }
@@ -558,12 +562,6 @@ SAML.prototype.validateSignatureForCert = function (signature, cert, fullXml, cu
 };
 
 SAML.prototype.validatePostResponse = function (container, callback) {
-  // if the cert is provided with an empty value it is invalid
-  if (this.options.hasOwnProperty('cert') &&
-      !this.options.cert) {
-    return callback(new Error('Invalid signature'));
-  }
-
   var self = this;
 
   var xml, doc, inResponseTo;

diff --git a/test/tests.js b/test/tests.js