Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

body-parser middleware is required but not documented. #250

Closed
clooudch opened this issue Nov 14, 2017 · 2 comments
Closed

body-parser middleware is required but not documented. #250

clooudch opened this issue Nov 14, 2017 · 2 comments

Comments

@clooudch
Copy link

I have found out that certain important informations are missing in the documentation. And I think that they possibly should be added to prevent further issues.

I wanted to use this module in a minimal setup. So I decided to not include the body-parser in the middleware pipeline. Unfortunately it turned out that the body-parser is required for this module to work. This dependency is not documented and is in no example included.

I think it would be best if you could add a notice somewhere in the documentation. It would also be okay if the module throws an error when the body-parser middleware is not available.

Please consider adding a notice somewhere or adding this information to the official documentation.

@markstos markstos changed the title Improve Documentation body-parser middleware is required but not documented. Jan 3, 2018
@markstos
Copy link
Contributor

markstos commented Jan 3, 2018

Closing as dupe of #128. Please search for dupes before opening new tickets.

@markstos markstos closed this as completed Jan 3, 2018
@markstos
Copy link
Contributor

markstos commented Jan 3, 2018

@clooudch you are welcome to contribute the refinements requested in PR #151

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants