Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add error for POST requests when req.body is undefined #151

Closed
wants to merge 1 commit into from

Conversation

jrop
Copy link

@jrop jrop commented Apr 15, 2016

Addresses #128

Sorry it took me so long to create this.

@pdspicer
Copy link
Contributor

pdspicer commented Mar 30, 2017

I think the check needs to be modified a little bit to potentially avoid "cannot read property 'SAMLResponse' of undefined" errors (i.e. check that req.body exists). In addition I think the check as currently written will break the HTTP-POST binding on SAMLRequests

@markstos
Copy link
Contributor

markstos commented Oct 9, 2017

Also, please add automated test coverage for this. Further, the error message doesn't exactly match the behavior. The error says: "req.body undefined for POST request", but the check is not for this, but for req.body.SAMLResponse. It's possible req.body.SAMLResponse could be undefined, while req.body is still defined.

@cjbarth
Copy link
Collaborator

cjbarth commented Mar 19, 2021

@jrop We will be releasing v3.x in the upcoming weeks. If you would like this included in that release, please address the latest comments and we'll get this landed.

@jrop
Copy link
Author

jrop commented Mar 19, 2021

@cjbarth I've since moved on from the job where I needed this, and will not get around to modifying this PR to address the comments. 😢

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants