Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the error 'TypeError: Cannot read property 'search' of undefined' #155

Closed
wants to merge 4 commits into from

Conversation

flashsnake-so
Copy link

To resolve this error, the xml-encryption has to update to 0.9.0. I am not sure why I am the only one in the world having this problem. I am using:

Node.js: 0.4.3
React

/Users/ericso/az/kancho/web/rubix-3.0/node_modules/passport-saml/node_modules/node-forge/js/util.js:1320
          _queryVariables = parse(window.location.search.substring(1));
                                                 ^

TypeError: Cannot read property 'search' of undefined
    at Object.util.getQueryVariables (/Users/ericso/az/kancho/web/rubix-3.0/node_modules/passport-saml/node_modules/node-forge/js/util.js:1320:50)
    at Array.initModule (/Users/ericso/az/kancho/web/rubix-3.0/node_modules/passport-saml/node_modules/node-forge/js/log.js:306:26)
    at Array.module.exports (/Users/ericso/az/kancho/web/rubix-3.0/node_modules/passport-saml/node_modules/node-forge/js/log.js:359:14)
    at Module.module.exports (/Users/ericso/az/kancho/web/rubix-3.0/node_modules/passport-saml/node_modules/node-forge/js/forge.js:42:14)
    at defineFunc (/Users/ericso/az/kancho/web/rubix-3.0/node_modules/passport-saml/node_modules/node-forge/js/forge.js:48:10)
    at /Users/ericso/az/kancho/web/rubix-3.0/node_modules/passport-saml/node_modules/node-forge/js/forge.js:86:14
    at define (/Users/ericso/az/kancho/web/rubix-3.0/node_modules/passport-saml/node_modules/node-forge/js/forge.js:15:7)
    at define (/Users/ericso/az/kancho/web/rubix-3.0/node_modules/passport-saml/node_modules/node-forge/js/forge.js:55:22)
    at /Users/ericso/az/kancho/web/rubix-3.0/node_modules/passport-saml/node_modules/node-forge/js/forge.js:60:1
    at Object.<anonymous> (/Users/ericso/az/kancho/web/rubix-3.0/node_modules/passport-saml/node_modules/node-forge/js/forge.js:88:3)

@flashsnake-so
Copy link
Author

Please help me to merge it sooner because it is currently blocking our development.

@flashsnake-so
Copy link
Author

oops.. not sure if the CI test fail is related to my change.

@flashsnake-so
Copy link
Author

flashsnake-so commented May 13, 2016

I just tried to rollback the xml-encryption to ~0.7 that I am seeing the same error.

@flashsnake-so
Copy link
Author

To avoid other CI test failed due to the new node stable version, please consider to merge this pull-request. Thanks.

@pdspicer
Copy link
Contributor

Hi, is updating dependencies what you are looking to do? If so I am in progress of doing just that, and will close this PR unless there's something else here

@4ossiblellc
Copy link

You need to update the dependency in package.json. I don't remember if I have a pull request for you.

@4ossiblellc
Copy link

Ops.. this is the pull request, can you merge this pull request?

@markstos
Copy link
Contributor

This PR expired. The module in question was updated elsewhere, and Node compatibilty was fixed elsewhere as well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants