Inflating redirect response #16
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
... some query string predefined Allow for passive IdP, for example, by adding ?IsPassive=true.
|
I've integrated most of the passport-saml-too changes into passport-saml, but I removed/disabled this one since verification wasn't implemented. |
|
It seems as if you merged - did you afterwards disabled it with adfitional commit? |
|
Yes, see 6f2087e. It would be good to have this functionality, but unless I'm missing something it would be a big security hole to have a path that doesn't validate signatures. |
stavros-wb
added a commit
to stavros-wb/passport-saml
that referenced
this pull request
Apr 5, 2018
• Builds on node-saml#16 • Reverts 638ce6e • Implements node-saml#191
stavros-wb
added a commit
to stavros-wb/passport-saml
that referenced
this pull request
Apr 11, 2018
• Builds on node-saml#16 • Reverts 638ce6e • Implements node-saml#191
stavros-wb
added a commit
to stavros-wb/passport-saml
that referenced
this pull request
Apr 11, 2018
• Builds on node-saml#16 • Reverts 638ce6e • Implements node-saml#191
stavros-wb
added a commit
to stavros-wb/passport-saml
that referenced
this pull request
Apr 11, 2018
• Builds on node-saml#16 • Reverts 638ce6e • Implements node-saml#191
stavros-wb
added a commit
to stavros-wb/passport-saml
that referenced
this pull request
Apr 12, 2018
• Builds on node-saml#16 • Reverts 638ce6e • Implements node-saml#191
stavros-wb
added a commit
to stavros-wb/passport-saml
that referenced
this pull request
Apr 12, 2018
• Builds on node-saml#16 • Reverts 638ce6e • Implements node-saml#191
stavros-wb
added a commit
to stavros-wb/passport-saml
that referenced
this pull request
Apr 12, 2018
• Builds on node-saml#16 • Reverts 638ce6e • Implements node-saml#191
stavros-wb
added a commit
to stavros-wb/passport-saml
that referenced
this pull request
Apr 12, 2018
• Builds on node-saml#16 • Reverts 638ce6e • Implements node-saml#191
stavros-wb
added a commit
to stavros-wb/passport-saml
that referenced
this pull request
Aug 28, 2018
• Builds on node-saml#16 • Reverts 638ce6e • Implements node-saml#191
stavros-wb
added a commit
to stavros-wb/passport-saml
that referenced
this pull request
Aug 28, 2018
• Builds on node-saml#16 • Reverts 638ce6e • Implements node-saml#191
stavros-wb
added a commit
to stavros-wb/passport-saml
that referenced
this pull request
Oct 2, 2018
• Builds on node-saml#16 • Reverts 638ce6e • Implements node-saml#191
stavros-wb
added a commit
to stavros-wb/passport-saml
that referenced
this pull request
Oct 4, 2018
• Builds on node-saml#16 • Reverts 638ce6e • Implements node-saml#191
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allows to call
authenticatenot only for Post but also for Redirect responses (typically, logout responses are redirect).TODO: Redirect responses are not verified, it needs different code than for Post case.