Fix: "TypeError: Cannot read property 'documentElement' of null" #239
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Before, these tests were spread out in 3 sub-sections. One was not labeled and the other two were not labeled as being for validatePostResponse. Now, more tests for this function are grouped together and clearly labeled, more consistent with how other tests in the file are handled.
…hole cert. copy/pasting a large chunk of encrypted text throughout the test file was error prone. Instead, we use a much shorter variable name for for the chunk.
Before, given junk input, validatePostResponse would fail with:
TypeError: Cannot read property 'documentElement' of null
Now we'll fail with:
SAMLResponse is not valid base64-encoded XML
To make this work, we primarily just needed to as a simple additional error check,
but to throw the error properly, we needed to move a bit of logic into
a nearby promise, but keeping some variable definitions in the outer
scope where they continue to be expected.
|
I'm going to ahead and merge this while I'm working on this project, but peer-review is still welcome. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See commit message in 8354683 and Issue #238 for details.