Many changes #31
Merged
Many changes #31
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
ploer
commented
May 29, 2014
ploer
commented
- Xpath fixes
- Most changes from passport-saml-too fork (redirect changes not included since they don't have authentication)
- Tolerate empty attribute sets (seen with OneLogin)
- Tolerate alternate namespace prefixes (seen with Okta)
- Add some tests
- Use xmlbuilder library to construct xml
- Upgrade library versions
... some query string predefined Allow for passive IdP, for example, by adding ?IsPassive=true.
Conflicts: lib/passport-saml/strategy.js
Now it was always login, but it can be logout as well (or nothing).
Conflicts: lib/passport-saml/strategy.js
…tead of an error.
…see if that helps 0.8 build.
…'t validate signatures.
This was referenced May 29, 2014
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.