Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(monorepo): move to monorepo structure, see #373 #383

Closed
wants to merge 2 commits into from

Conversation

sibelius
Copy link
Contributor

This is moving the current package to a monorepo structure

@markstos
Copy link
Contributor

Sorry for the massive delay. This is a necessary large diff that's a bit hard to scan. After setting up the monorepo structure, does it result in one project (for now) in the monorepo or two? I'm inclined to merge this into a v2 branch.

@sibelius
Copy link
Contributor Author

only 1 package

after being stable, we can start moving to more packages

@markstos
Copy link
Contributor

This has been merged into v2 branch: https://github.com/bergie/passport-saml/tree/v2 Closing here. Thanks!

@sibelius
Copy link
Contributor Author

great

@markstos
Copy link
Contributor

I'm re-evaluating merging this on the active branch to avoid effort to sync them later. Am I correct that this is purely an internal refactor with no user-visible changes (and therefore safe to merge?).

@sibelius
Copy link
Contributor Author

you can check the pull request code.

I just change some paths to fix tests

it is safe to merge

@sibelius
Copy link
Contributor Author

@markstos anything I can do to move on?

@markstos
Copy link
Contributor

Sorry for the delay. Rebase this onto the main branch and I'll merge it on the main branch.

@sibelius
Copy link
Contributor Author

merged with master, we may need to fix eslint later on

@cjbarth
Copy link
Collaborator

cjbarth commented Nov 19, 2019

@sibelius It seems there are still conflicts. But I would like to make sure that eslint isn't one of the problems. What did you discover in eslint that may need attention?

@sibelius
Copy link
Contributor Author

@cjbarth feel free to finish this pull request, the eslint broke because it was one config when I started working on this pull request, and then changed to another one

@markstos
Copy link
Contributor

Today I rebased this and pushed it here: https://github.com/bergie/passport-saml/pull/new/feat/monorepo

However, both yarn test and yarn lint return errors that I don't have to investigate now.

There's also a related effort going on now in #409 to split the project into an internal and external projects.

If someone wants to look into the issue in the related fork I created, that would be helpful. It would also be helpful to leave a comment here which explains more about how the new structure is intended to work. Assume the contributors here are new to using Lerna.

@markstos
Copy link
Contributor

I'm abandoning this in favor of more recent forks to rewrite the project in TypeScript and split out the internal SAML library into a separate project.

@markstos markstos closed this Jul 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants