Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

convert privateCert to PEM for signing #390

Merged

Conversation

warncke
Copy link

@warncke warncke commented Sep 5, 2019

allow privateCert to be passed in as base64 string without PEM formatting the same as cert.

@markstos
Copy link
Contributor

I might use this myself. Please amend your commit to update the docs as well and I think I'll merge this.

The version of systemd on Ubuntu 18.04 doesn't like newlines in environment variables, so this will be a welcome update for those who want to store the PEM in a one-line environment variable.

@cjbarth
Copy link
Collaborator

cjbarth commented Nov 18, 2019

@warncke I second @markstos comments. Please update the docs and lets get this landed.

@warncke
Copy link
Author

warncke commented Jan 21, 2020

@markstos @cjbarth sorry for the long delay on this. I have update the readme to try to accurately reflect the change.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants