Return object for XML-valued AttributeValues #447
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mans0954
changed the title
|
I haven't traced all the code paths on this one, but it looks reasonable to me. Thank you for the test. |
|
Thanks for referencing the spec, too. I hope to catch up on passport-saml mail soon. @cjbarth feel free to merge PRs that look good. |
walokra
pushed a commit
to walokra/suomifi-passport-saml
that referenced
this pull request
Oct 1, 2020
* upstream: docs: remove badges broken by project rename. bump version to 1.3.5 deps: really bump xml-encryption for node-forge sub-dep upgrade to address vuln. docs: Update package.json / README to reflect site move. deps: bump xml-encryption to address node-forge sub-dep vuln. Update issue templates Update issue templates Bump lodash from 4.17.15 to 4.17.20 (node-saml#449) Bump acorn from 7.1.0 to 7.4.0 (node-saml#448) Return object for XML-valued AttributeValues (node-saml#447) Revert "doc: announce site move." (node-saml#446) doc: announce site move. add yarn-error.log to .gitignore bump version. Fix multi saml strategy race conditions (node-saml#426) v1.3.3 v1.3.2 # Conflicts: # .gitignore # README.md # package.json
walokra
added a commit
to walokra/suomifi-passport-saml
that referenced
this pull request
Oct 2, 2020
* upstream: docs: remove badges broken by project rename. bump version to 1.3.5 deps: really bump xml-encryption for node-forge sub-dep upgrade to address vuln. docs: Update package.json / README to reflect site move. deps: bump xml-encryption to address node-forge sub-dep vuln. Update issue templates Update issue templates Bump lodash from 4.17.15 to 4.17.20 (node-saml#449) Bump acorn from 7.1.0 to 7.4.0 (node-saml#448) Return object for XML-valued AttributeValues (node-saml#447) Revert "doc: announce site move." (node-saml#446) doc: announce site move. add yarn-error.log to .gitignore bump version. Fix multi saml strategy race conditions (node-saml#426) v1.3.3 v1.3.2 # Conflicts: # .gitignore # README.md # package.json
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: #245
saml-core-2.0-os Section 2.7.3.1.1 says
This PR modifies the
attrValueMapperfunction to return an object representing the parsed XML unless the attribute is a simple string, in which case the string is returned.A test is included which also serves as an example of how this functionality can be used in the specific case of the deprecated eduPersonTargetedID attribute.