fix: disable esmoduleInterop setting #483
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This patch disables the `esmoduleInterop` setting that causes type issues when the library is used by applications that do not transform their code in this way. Note the workaround for the `strategy.ts` file (import = require()) is not ideal, but the export in that file is not a valid ES export, so using this TS workaround to get past it. fixes: #482
gugu
approved these changes
Oct 30, 2020
|
I agree, personally, I don't like esmoduleInterop setting, I forgot to turn it off |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch disables the
esmoduleInteropsetting that causes type issues when the library is used by applications that do not transform their code in this way.Note the workaround for the
strategy.tsfile (import = require()) is not ideal, but the export in that file is not a valid ES export, so using this TS workaround to get past it.fixes: #482